Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect xinetd service pattern and generate correct pattern (ONME-3733) #8645

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Detect xinetd service pattern and generate correct pattern (ONME-3733) #8645

merged 1 commit into from
Nov 8, 2018
+33 −14

Conversation

mtomczykmobica
Copy link
Contributor

Description

Task ONE-3733. Add support for xinetd chargen service. Modify pattern creation function to be compatible with xinetd chargen service.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@mtomczykmobica
Copy link
Contributor Author

@SeppoTakalo please review.

@SeppoTakalo
Copy link
Contributor

Looks good

0xc0170
0xc0170 requested changes Nov 6, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review astyle travis job

jeromecoutant
jeromecoutant approved these changes Nov 6, 2018
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested OK with local ST server with XINETD service
and still OK with ARM server (echo.mbedcloudtesting.com)

@jeromecoutant
Copy link
Collaborator

Note that ONME-3733 seems to be #7292
Maybe it's better to use github Id instead of ARM internal Id 😕
Thx @mtomczykmobica for the fix

@mtomczykmobica
Copy link
Contributor Author

mtomczykmobica commented Nov 6, 2018 •
edited
Loading

astyle fixed. @0xc0170 please review.

@SeppoTakalo
Copy link
Contributor

I can still see couple of things the Astyle changed:
https://travis-ci.org/ARMmbed/mbed-os/jobs/451318512

One is just whitespace at the end of line. Others are visible.

@mtomczykmobica
Copy link
Contributor Author

FIxed.

cmonr
cmonr approved these changes Nov 7, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat!

@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2018

Build : SUCCESS

Build number : 3575
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8645/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2018

Exporter Build : SUCCESS

Build number : 3186
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8645/

@mbed-ci
Copy link

mbed-ci commented Nov 8, 2018

Test : SUCCESS

Build number : 3354
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8645/3354

@0xc0170 0xc0170 changed the title ONME-3733 detect xinetd service pattern and generate correct pattern Detect xinetd service pattern and generate correct pattern (ONME-3733) Nov 8, 2018
@0xc0170 0xc0170 merged commit 937d68f into ARMmbed:master Nov 8, 2018
@SeppoTakalo SeppoTakalo mentioned this pull request Nov 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@SeppoTakalo SeppoTakalo SeppoTakalo approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mtomczykmobica @SeppoTakalo @jeromecoutant @NirSonnenschein @mbed-ci @cmonr @0xc0170